Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Path: utzoo!mnetor!uunet!steinmetz!jesup
From: jesup@steinmetz.steinmetz.UUCP (Randell Jesup)
Newsgroups: comp.mail.uucp
Subject: Re: Bugs in DCP (uupc)
Message-ID: <7208@steinmetz.steinmetz.UUCP>
Date: Thu, 3-Sep-87 01:59:41 EDT
Article-I.D.: steinmet.7208
Posted: Thu Sep  3 01:59:41 1987
Date-Received: Sat, 5-Sep-87 08:21:33 EDT
References: <7156@steinmetz.steinmetz.UUCP> <7188@steinmetz.steinmetz.UUCP>
Reply-To: jesup@steinmetz.UUCP (Randell Jesup)
Organization: General Electric CRD, Schenectady, NY
Lines: 24

I have found 2 more serious bugs in dcp (uupc), in the system-independant
code.

First, in dcp.c, in dcpmain, there is a statement
			case 'G':
				if ( strcmp( Rmtname, "any" ) != SAME)
					state = 'Y';
				else
					state = 'I';
This causes sysend to be calledfor each line in the systems file until it
reaches the system you want to call (uupc -ssystem).  Calling sysend before
opening the serial port, at least on the Amiga, can have fatal results.
The meaning of the conditional should be flipped, to ==.

Second, in mail.c, there is a
	#define exit return
The only place it is used is in the routine finis(), which is called in such
a way that it is obviously assumed not to return.  
I kludged it by putting a return after every call to finis(), but I doubt
that that's correct.  Any comments/help?
-- 
	Randell Jesup  (Please use one of these paths for mail)
	jesup@steinmetz.UUCP (uunet!steinmetz!jesup)
	jesup@ge-crd.ARPA