Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Path: utzoo!utgpu!water!watmath!clyde!rutgers!mit-eddie!genrad!decvax!decwrl!pyramid!prls!philabs!micomvax!musocs!mcgill-vision!mouse
From: mouse@mcgill-vision.UUCP
Newsgroups: comp.sys.amiga,comp.sources.bugs
Subject: Re: Bug in uupc
Message-ID: <891@mcgill-vision.UUCP>
Date: Sat, 19-Sep-87 05:50:22 EDT
Article-I.D.: mcgill-v.891
Posted: Sat Sep 19 05:50:22 1987
Date-Received: Sun, 27-Sep-87 23:03:59 EDT
References: <563@sugar.UUCP>
Organization: McGill University, Montreal
Lines: 17
Keywords: uupc amiga genv.c getone()
Xref: utgpu comp.sys.amiga:8250 comp.sources.bugs:306

In article <563@sugar.UUCP>, peter@sugar.UUCP (Peter da Silva) writes:
> The following [...] complex version of fgetc(fp) has a serious bug in
> it.  It's from "genv.c" in the Amiga code for the uupc program.

> Basically, line[256] has to be static.

Not only that: even if you do make it static, the function will break
badly if called with various different stdio streams, since if there is
something in its buffer it *ignores* its argument!  But it's all
academic because, as you point out, it

> ... is entirely superfluous since it's identical in function to
> "fgetc()".

					der Mouse

				(mouse@mcgill-vision.uucp)