Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Path: utzoo!mnetor!uunet!peregrine!imt3b2!imtsft
From: imtsft@imt3b2.UUCP (IMT)
Newsgroups: news.software.b
Subject: Patch 11 breaks expire
Message-ID: <3070@imt3b2.UUCP>
Date: Tue, 20-Oct-87 05:01:07 EDT
Article-I.D.: imt3b2.3070
Posted: Tue Oct 20 05:01:07 1987
Date-Received: Fri, 23-Oct-87 06:02:42 EDT
Organization: IMT Inc., Mission Viejo, CA.
Lines: 61
Keywords: non dbm systems have history destroyed


Come on folks! How about testing the patches to usenet software BEFORE they
go out. Patch 11 broke expire on systems that do not have dbm and use the
history file (as is the normal case) for expiring articles. Expire builds
a NARTFILE during the expiration process and then attempts to read the
ARTFILE to rebuild the history subfiles. This ONLY works when an ARTFILE
exists. The result is that a message indicating a non existing file
(/usr/lib/news/history) is produced and your current history (history.d/*)
is gone (all zero length files). Prior to Patch 11, the NARTFILE was
renamed to ARTFILE before the rebuild. Patch 11 took it out.
This puts it back in.


*** expire.c.old	Tue Oct 20 01:20:46 1987
--- expire.c	Tue Oct 20 01:23:08 1987
***************
*** 767,772
  	if (dorebuild || !nohistory) {
  #ifdef DBM
  		(void) rename(ARTFILE, OARTFILE);
  		(void) rename(NARTFILE, ARTFILE);
  		if (dorebuild)
  			rebuilddbm( );

--- 767,773 -----
  	if (dorebuild || !nohistory) {
  #ifdef DBM
  		(void) rename(ARTFILE, OARTFILE);
+ #endif /* !DBM */
  		(void) rename(NARTFILE, ARTFILE);
  #ifdef DBM
  		if (dorebuild)
***************
*** 768,773
  #ifdef DBM
  		(void) rename(ARTFILE, OARTFILE);
  		(void) rename(NARTFILE, ARTFILE);
  		if (dorebuild)
  			rebuilddbm( );
  		else {

--- 769,775 -----
  		(void) rename(ARTFILE, OARTFILE);
  #endif /* !DBM */
  		(void) rename(NARTFILE, ARTFILE);
+ #ifdef DBM
  		if (dorebuild)
  			rebuilddbm( );
  		else {

--- end of diffs

------------------------------------------------------------------------------
name	: IMT (Group Administrator)
email	: ...(ccicpg|peregrine)!imt3b2!imtsft
------------------------------------------------------------------------------
-- 
---
Paul Czarnik
---