Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Path: utzoo!utgpu!water!watmath!clyde!rutgers!mit-eddie!bloom-beacon!athena.mit.edu!tytso
From: tytso@athena.mit.edu.UUCP
Newsgroups: comp.bugs.4bsd
Subject: bug in csh
Message-ID: <1882@bloom-beacon.MIT.EDU>
Date: Tue, 24-Nov-87 17:43:43 EST
Article-I.D.: bloom-be.1882
Posted: Tue Nov 24 17:43:43 1987
Date-Received: Sat, 28-Nov-87 07:03:48 EST
Sender: daemon@bloom-beacon.MIT.EDU
Reply-To: tytso@athena.mit.edu (Theodore Y. Ts'o)
Organization: Massachusetts Institute of Technology
Lines: 56

Bug:
	When shell builtins bomb out in .logout, the logout is aborted.

Repeat by:
	(don't do this as root :-)

Script started on Tue Nov 24 17:15:42 1987
<tytso@paris>   {/mit/t/y/tytso}, Level 2
1% mv .logout .logout.real
<tytso@paris>   {/mit/t/y/tytso}, Level 2
2% cat >.logout
kill 1
^D
<tytso@paris>   {/mit/t/y/tytso}, Level 2
3% ln -s /bin/csh -
<tytso@paris>   {/mit/t/y/tytso}, Level 2
4% -				<===== Fake a login shell
IBM RT<n>? ^C			<===== Abort login sequenece
<tytso@paris>   {/mit/t/y/tytso}, Level 3
1% logout
1: Not owner
<tytso@paris>   {/mit/t/y/tytso}, Level 3
2% logout
1: Not owner
<tytso@paris>   {/mit/t/y/tytso}, Level 3
3% logout
1: Not owner
<tytso@paris>   {/mit/t/y/tytso}, Level 3
4% logout
1: Not owner
<tytso@paris>   {/mit/t/y/tytso}, Level 3
5% ^D
logout
1: Not owner
<tytso@paris>   {/mit/t/y/tytso}, Level 2
5% ^D

script done on Tue Nov 24 17:16:57 1987

Fix:
*** /source/4.3/bin/tcsh/sh.c   Sat Nov 21 23:02:31 1987
--- sh.c        Tue Nov 24 17:35:21 1987
***************
*** 697,702 ****
--- 697,703 ----
  goodbye()
  {
        rechist();
+       child++;                /* On errors, DIE! */
        if (loginsh) {
                (void) signal(SIGQUIT, SIG_IGN);
  #ifdef COMPAT42