Path: utzoo!utgpu!water!watmath!clyde!rutgers!husc6!necntc!ncoast!allbery
From: lvc@tut.cis.ohio-state.edu (Lawrence V. Cipriani)
Newsgroups: comp.sources.misc
Subject: v02i012: Patches for File System Analyzer Tool
Summary: bugs in IS_SPECIAL macro
Message-ID: <7105@ncoast.UUCP>
Date: 20 Jan 88 01:12:06 GMT
Sender: allbery@ncoast.UUCP
Organization: Ohio State Computer & Info Science
Lines: 19
Approved: allbery@ncoast.UUCP
X-Archive: comp.sources.misc/8801/12
Comp.sources.misc: Volume 2, Issue 12
Submitted-By: Lawrence V. Cipriani <lvc@tut.cis.ohio-state.edu>
Archive-Name: fs-analyzer/patch1

Comp.sources.misc: Volume 2, Issue 12
Submitted-By: Lawrence V. Cipriani <lvc@tut.cis.ohio-state.edu>
Archive-Name: fs-analyzer/patch1

The system 5 file system analysis program contains 3 bugs in the
definition of the IS_SPECIAL macro.  It is defined at line 87 of
the fsanalyze.c file.

# define IS_SPECIAL(a)	(((a) & S_IFMT == S_IFBLK) ||
	((a) & S_IFMT == S_IFCHR) || ((a) & S_IFMT == S_IFIFO))

It should be:

# define IS_SPECIAL(a)	((((a) & S_IFMT) == S_IFBLK) ||
	(((a) & S_IFMT) == S_IFCHR) || (((a) & S_IFMT) == S_IFIFO))
-- 
Larry Cipriani - using a guest account at
lvc@tut.cis.ohio-state.edu a.k.a.
...!cbosgd!osu-cis!tut.cis.ohio-state.edu!lvc