Path: utzoo!utgpu!water!watmath!clyde!rutgers!ames!ucbcad!pasteur!ucbvax!decvax!decwrl!sun!pitstop!sundc!seismo!uunet!mcvax!ukc!dcl-cs!nott-cs!pyr1.cs.ucl.ac.uk!awylie
From: awylie@pyr1.cs.ucl.ac.uk
Newsgroups: comp.sys.ibm.pc
Subject: Re: A Hercules Primer
Message-ID: <39500005@pyr1.cs.ucl.ac.uk>
Date: 18 Jan 88 14:47:00 GMT
References: <1866@ingr.UUCP>
Lines: 32
Nf-ID: #R:ingr.UUCP:-186600:pyr1.cs.ucl.ac.uk:39500005:000:1502
Nf-From: pyr1.cs.ucl.ac.uk!awylie    Jan 18 14:47:00 1988


This posting is appalling. Your routines contain some horrendous bugs.
It will not even compile under Microsoft-C. Initialization of automatic
arrays!!! What broken compiler accpets this??? Even if you did somehow
compile it, several of the routines could never work -
  set_text has incorrect loop index : try to go from graphics mode
           back to text and KABLAM REBOOT TIME
  get_screen and save_screen do an illegal trick to convert the screen
           address to a long pointer ("weird" is your comment) but my
           compiler complains that the pointer is converted to short
           again when the memcpy (or memmove, I forget) routine is called
           to do the dirty work.
            These two routines also do not bother checking that fopen has
          been successful.

There are other horrors in there which I will not mention. Stylistically
the whole thing is a mess too, eg capital letters in non-preprocessor
variables.

Anyone who would like to get a working version of this mess, with also a
routine to display text whilst in graphics mode, send me an e-mail.
------------------------------------------------------------
Andrew Wylie, University of London Computer Centre,
20 Guilford Street, London WC1N 1DZ, England.

JANET:      andrew@uk.ac.ulcc.ncdlab
UUCP:              ..!mcvax!ukc!cs.ucl.ac.uk!awylie
ARPA:              awylie@cs.ucl.ac.uk
BITNET:     andrew%uk.ac.ulcc.ncdlab@ac.uk

If replying via satnet please give a UUCP path from mcvax to
your site.