Path: utzoo!attcan!uunet!husc6!cs.utexas.edu!ut-sally!ut-emx!mic
From: mic@ut-emx.UUCP (Mic (... K[a-z]+) Kaczmarczik)
Newsgroups: comp.sys.amiga
Subject: Re: Bug in MG2a
Summary: oops. too many compilation options can mean trouble.
Keywords: fix
Message-ID: <3255@ut-emx.UUCP>
Date: 11 Jun 88 22:03:21 GMT
References: <474@amanpt1.zone1.com>
Reply-To: mic@emx.UUCP (Mic Kaczmarczik)
Organization: UT Austin Computation Center, User Services Unix Support Group
Lines: 37

In article <474@amanpt1.zone1.com> mrr@amanpt1.zone1.com (Mark Rinfret) writes:
>I fixed a bug in my copy of MG2a last night.  This was revealed by the "task
>held" requester after selecting the "Set Mark" menu item (which tells you 
>that I compiled in the MENU option).  To be brief, in file 
>sys/amiga/ttymenu.c, function amigamenu, there is a line:
>
>	return (*(fp)(f,n));
>
>which should really be:
>
>	return ((*fp)(f,n));
>
	Guilty as charged.  One of the problems with all the compile-time
	configuration stuff in mg (and other programs in general) is that
	it's often difficult to test everything.  When I rewrote the menu
	code to call the functions directly instead of using up more string
	space, I never tested the menu code without the Browser compiled in.
	
	A few lines further down, in the BROWSER + MENU code, there is a
	correct call via the function pointer.  I'll send in a patch to
	mg-developers, so it'll be fixed in the next release.

Sigh,

--mic--

>< Mark R. Rinfret,  mrr@amanpt1.ZONE1.COM | ...rayssd!galaxia!amanpt1!mrr    >
>< AMA / HyperView Systems               Home: 401-846-7639                   >
>< 28 Jacome Way                         Work: 401-849-9930 x301              >
>< Middletown, RI 02840          	"If I just had a little more time...">


-- 
Mic Kaczmarczik			If you drink, don't drill.
UT Austin Computation Center			-- Matt Groening
mic@emx.utexas.edu	
MIC@UTAIVC.BITNET