Path: utzoo!attcan!uunet!munnari!otc!metro!sunaus!richb
From: richb@sunaus.oz (Rich Burridge)
Newsgroups: comp.sources.bugs
Subject: Small bug in Touchup, the bitmap editor.
Keywords: Problem in 4.0 (seems to accidentally work in 3.5).
Message-ID: <175@sunaus.oz>
Date: 15 Jun 88 08:18:17 GMT
Organization: Sun Microsystems, Sydney
Lines: 23

I see the problem on a 3/60C-8-327 running 4.0(FCS)(EXPORT).
Touchup core dumps with a segmentation violation whilst trying
to copy the current screen contents to a temporary buffer, so the
undo command will work if used. This is because the pixrect pointer
for that temporary buffer is a nil pointer.

The memory create routine in touchup.c called my_memory_create is
failing to return the newly created pixrect pointer. The fix is simple:

*** touchup.c.original  Wed Jun 15 18:08:36 1988
--- touchup.c   Wed Jun 15 18:08:20 1988
***************
*** 775,778 ****
--- 775,779 ----
        printf("Not enough memory, memory allocation problems!!!\n");
        exit(0);
          }
+     return(temp_pr);
  }

This is a fantastic program. My hat is off to the author.

    Rich.