Path: utzoo!utgpu!water!watmath!clyde!att!osu-cis!tut.cis.ohio-state.edu!rutgers!ucsd!ucsdhub!sdsu!mullen From: mullen@sdsu.UUCP (deborah mullen) Newsgroups: comp.os.minix Subject: 1.3c more notes Message-ID: <3193@sdsu.UUCP> Date: 7 Oct 88 05:27:00 GMT Organization: San Diego State University, Math/Sciences Dept. Lines: 15 Unless I lost a character when downloading (never happened before), line 204 of console.c (1.3c update) is missing a closing comment. I assume this would cause the next line of code to be skipped. The PUBLIC and PRIVATE directives do not mean much. There are many routines declared PRIVATE that are called from other source files. Examples include flush, set_leds, tty_init, ..... I know the MINIX compiler does not care, but for the sake of documentation. How much was this version tested after all the new stuff was added? I'm not that keen on all the ega stuff. It makes the code large and messy. I believe the author was expressing some doubts in one of his postings also. -- Deborah Mullen