Path: utzoo!utgpu!attcan!uunet!husc6!rutgers!att!ucbvax!OKEEFFE.BERKELEY.EDU!torek
From: torek@OKEEFFE.BERKELEY.EDU (Chris Torek)
Newsgroups: comp.protocols.tcp-ip
Subject: Re:  4.3bsd imp going down crash?
Message-ID: <8811012114.AA27419@okeeffe.Berkeley.EDU>
Date: 1 Nov 88 21:14:45 GMT
Sender: daemon@ucbvax.BERKELEY.EDU
Organization: The Internet
Lines: 68

Most likely you ran into the bug fixed below.  This (and others) are
fixed in the 4.3BSD-tahoe networking code, and probably in the upgrade
for 4.3BSD that is (was?) on ucbarpa.

Chris

*** if_imphost.c.7.3	Tue Nov  1 13:10:09 1988
--- if_imphost.c.7.4	Tue Nov  1 13:10:18 1988
***************
*** 10,14 ****
   * is provided ``as is'' without express or implied warranty.
   *
!  *	@(#)if_imphost.c	7.3 (Berkeley) 2/8/88
   */
  
--- 10,14 ----
   * is provided ``as is'' without express or implied warranty.
   *
!  *	@(#)if_imphost.c	7.4 (Berkeley) 2/8/88
   */
  
***************
*** 201,204 ****
--- 201,205 ----
  	register struct mbuf *m;
  	register struct host *hp, *lp;
+ 	struct imp_softc *sc;
  	struct hmbuf *hm;
  	int s = splimp(), unit, any;
***************
*** 206,210 ****
  	for (unit = 0; unit < NIMP; unit++) {
  	    any = 0;
! 	    for (m = imp_softc[unit].imp_hosts; m; m = m->m_next) {
  		hm = mtod(m, struct hmbuf *);
  		hp = hm->hm_hosts; 
--- 207,212 ----
  	for (unit = 0; unit < NIMP; unit++) {
  	    any = 0;
! 	    sc = &imp_softc[unit];
! 	    for (m = sc->imp_hosts; m; m = m->m_next) {
  		hm = mtod(m, struct hmbuf *);
  		hp = hm->hm_hosts; 
***************
*** 221,224 ****
--- 223,228 ----
  				any = 1;
  				hostrelease(hp);
+ 				if (sc->imp_hostq == m)
+ 					sc->imp_hostq = 0;
  			}
  		    }
***************
*** 225,230 ****
  		}
  	    }
! 	    if (any)
  		hostcompress(unit);
  	}
  	splx(s);
--- 229,235 ----
  		}
  	    }
! 	    if (any) {
  		hostcompress(unit);
+ 	    }
  	}
  	splx(s);