Path: utzoo!utgpu!watmath!clyde!att!osu-cis!tut.cis.ohio-state.edu!cwjcc!hal!nic.MR.NET!shamash!com50!pai!pfh
From: pfh@pai.UUCP (Peter Hill)
Newsgroups: comp.windows.x
Subject: Re: Purdue speedups to X11 Release 3 mfb code
Summary: compiler errors under SunOS 3.2 +FIX
Message-ID: <292@pai.UUCP>
Date: 26 Nov 88 23:25:06 GMT
References: <5462@medusa.cs.purdue.edu>
Organization: Prime Automation, Inc., Burnsville, MN
Lines: 69

In article <5462@medusa.cs.purdue.edu>, spaf@cs.purdue.EDU (Gene Spafford)
writes:
> 
> I have just sent to comp.sources.x my patches to X11 Release 3 to
> speed up the mfb (monochrome) server performance.

Thanks, Gene!  The speedups are very nice indeed.  Now for a problem report:


VERSION:
    X.V11R3 + patches 1-2 + Purdue-speedups.mfb

CLIENT MACHINE and OPERATING SYSTEM:
    Sun 3/160M, SunOS 3.2

DISPLAY:
    Sun BW2

AREA:
    mfb speedups

DESCRIPTION:
    Neither mfbsetsp.c nor mfbbitblt.c would compile under SunOS 3.2,
    apparently because of the new putbitsrop() macro in maskbits.h.
    See code below for details.

FIX:
    Perhaps there is a better/easier way to fix this.  Below is a
    context diff of my hacks to maskbits.h.  This patch can be applied
    after applying maskbits.h.patch from Purdue-speedups.mfb.


------cut here-----
*** ddx/mfb/maskbits.h.purdue	Fri Nov 25 19:52:54 1988
--- ddx/mfb/maskbits.h	Sat Nov 26 10:35:38 1988
***************
*** 353,363 ****
      else \
      { \
  	int m = 32-(x); \
  	register unsigned int *ptmp_ = (unsigned *) (pdst)+1; \
! 	*(pdst) = (*(pdst) & endtab[x]) | (t2 & starttab[x]); \
  	t1 = SCRLEFT((src), m); \
  	DoRop(t2, rop, t1, *ptmp_); \
! 	*ptmp_ = (*ptmp_ & starttab[n]) | (t2 & endtab[n]); \
      } \
  }
  
--- 353,366 ----
      else \
      { \
  	int m = 32-(x); \
+ 	register int t3; \
  	register unsigned int *ptmp_ = (unsigned *) (pdst)+1; \
! 	t3 = t2 & starttab[x]; \
! 	*(pdst) = (*(pdst) & endtab[x]) | t3; \
  	t1 = SCRLEFT((src), m); \
  	DoRop(t2, rop, t1, *ptmp_); \
! 	t3 = t2 & endtab[n]; \
! 	*ptmp_ = (*ptmp_ & starttab[n]) | t3; \
      } \
  }
  
------cut here-----

-- 
______________________________________________________________________________
Peter Hill                          pfh@pai.mn.org             +1 612 894 0313
Prime Automation, Inc.              ...{sun!tundra,umn-cs!hall,bungia}!pai!pfh