Path: utzoo!utgpu!watmath!uunet!bu-cs!bloom-beacon!tut.cis.ohio-state.edu!triceratops.cis.ohio-state.edu!karl
From: karl@triceratops.cis.ohio-state.edu (Karl Kleinpaste)
Newsgroups: gnu.emacs.gnus
Subject: Bug fix for a couple of 3.10 problems
Message-ID: <KARL.88Nov16093245@triceratops.cis.ohio-state.edu>
Date: 16 Nov 88 14:32:45 GMT
Sender: news@tut.cis.ohio-state.edu
Distribution: gnu
Organization: OSU
Lines: 71

Two things about 3.10.

First, in the Path: header, We Believe In Domains, and we like all
host references to show up with fully-qualified domain names.

Actually, I would argue that GNUS shouldn't be messing with Path: at
all, since Path: is correctly created by whichever version of inews is
in use.  A similar thought applies to Message-Id; why does GNUS
bother, when inews builds a correct Message-Id?

Second, since inews (both NNTP and local, direct versions) include
.signature files, it seems inappropriate for GNUS to include them as
well, since it will cause doubled signature inclusions.
Per-distribution .signatures might be nice, but they rather conflict
with normal inews activities.

Context diff follows to correct these items.

These minor matters aside, I'm quite impressed and I like GNUS a lot.

--Karl

*** gnus.el.~1~ Tue Nov 15 15:56:52 1988
--- gnus.el     Wed Nov 16 09:05:47 1988
***************
*** 4823,4833 ****
        (if (file-exists-p (concat signature "-" distribution))
          (setq signature (concat signature "-" distribution)))
        ;; Insert signature.
!       (if (file-exists-p signature)
!         (progn
!           (goto-char (point-max))
!           (insert "--\n")
!           (insert-file-contents signature)))
        ;; Prepare article headers.
        (save-restriction
        (goto-char (point-min))
--- 4823,4833 ----
        (if (file-exists-p (concat signature "-" distribution))
          (setq signature (concat signature "-" distribution)))
        ;; Insert signature.
! ;;    (if (file-exists-p signature)
! ;;      (progn
! ;;        (goto-char (point-max))
! ;;        (insert "--\n")
! ;;        (insert-file-contents signature)))
        ;; Prepare article headers.
        (save-restriction
        (goto-char (point-min))
***************
*** 4926,4932 ****
           (organization (or (getenv "ORGANIZATION") gnus-your-organization)))
        ;; Insert from top of headers.
        (goto-char (point-min))
!       (insert "Path: " gnus-nntp-server "!" gnus-user-login-name "\n"
              "From: " (gnus-inews-user-name)
              (if (or (string-equal gnus-user-full-name "")
                      (string-equal gnus-user-full-name "&"))
--- 4926,4933 ----
           (organization (or (getenv "ORGANIZATION") gnus-your-organization)))
        ;; Insert from top of headers.
        (goto-char (point-min))
!       (insert "Path: " (gnus-inews-domain-name gnus-use-generic-from)
!             "!" gnus-user-login-name "\n"
              "From: " (gnus-inews-user-name)
              (if (or (string-equal gnus-user-full-name "")
                      (string-equal gnus-user-full-name "&"))
-=-
"He even writes obnoxious LISP CODE!"
	-- A local Lisp hacker and AI expert, having tried
	   (thus far unsuccessfully) to bring up Gnews 2.0.