Path: utzoo!attcan!uunet!lll-winken!lll-lcc!ames!pasteur!ucbvax!GARNET.BERKELEY.EDU!rusty
From: rusty@GARNET.BERKELEY.EDU
Newsgroups: comp.windows.x
Subject: bugs in Purdue+ speedups
Message-ID: <8812160711.AA17436@garnet.berkeley.edu>
Date: 16 Dec 88 07:11:47 GMT
Sender: daemon@ucbvax.BERKELEY.EDU
Lines: 46

The line numbers are from diffs done on the maskbits.h file, not the
patch file.  They are off by at least 2 because I added an SCCS
comment at the top.

The first bug is a missing backslash that I noticed when trying to
find the second bug.  The problem with the second bug is that there's
a space after the backslash that's escaping that space rather than the
newline; therefore the brace on the following line wasn't becoming
part of the macro.  I ran into this compiling the server with cc.

------- maskbits.h -------
*** /tmp/da9129	Thu Dec 15 23:03:18 1988
--- maskbits.h	Thu Dec 15 23:01:38 1988
***************
*** 474,480 ****
  	if ( ((int)(psrc)) & 0x01 ) \
  		getbits( ((unsigned int *)(((char *)(psrc))-1)), 8, (w), (dst) ); \
  	else \
! 		getbits(psrc, 0, w, dst)
      }
  #endif /* GETLEFTBITS_ALIGNMENT == 2 */
  
--- 474,480 ----
  	if ( ((int)(psrc)) & 0x01 ) \
  		getbits( ((unsigned int *)(((char *)(psrc))-1)), 8, (w), (dst) ); \
  	else \
! 		getbits(psrc, 0, w, dst) \
      }
  #endif /* GETLEFTBITS_ALIGNMENT == 2 */
  
***************
*** 609,615 ****
  { \
      register unsigned int _tmpbits; \
      getbits(psrc, srcbit, width, _tmpbits); \
!     putbits(_tmpbits, dstbit, width, pdst); \ 
  }
  
  #define getandputrop(psrc, srcbit, dstbit, width, pdst, rop) \
--- 609,615 ----
  { \
      register unsigned int _tmpbits; \
      getbits(psrc, srcbit, width, _tmpbits); \
!     putbits(_tmpbits, dstbit, width, pdst); \
  }
  
  #define getandputrop(psrc, srcbit, dstbit, width, pdst, rop) \