Path: utzoo!utgpu!jarvis.csri.toronto.edu!mailrus!nrl-cmf!ukma!tut.cis.ohio-state.edu!rutgers!att!alberta!ubc-cs!eric!eric.mpr.ca!froese
From: froese@eric.mpr.ca (Edwin Froese)
Newsgroups: comp.os.minix
Subject: 1.4a report
Message-ID: <1568@eric.mpr.ca>
Date: 13 Feb 89 01:33:35 GMT
Sender: news@eric.mpr.ca
Reply-To: froese@eric.mpr.ca (Edwin Froese)
Organization: Microtel Pacific Research Ltd., Burnaby, B.C., Canada
Lines: 75

Bruce Evans previously posted (1633@ditsyda.oz) a list of
problems with the 1.4a posting. We noticed a few more:


system(3) - There should be a (char *) 0 in the execl().

rename(3) - There was a more robust version posted by Freeman
	    Pascal.

fortune(1) - Getuid() should never be used for a seed calculation,
	     this makes it horrendously non-random.

dosread(1) - Its getting so large that it should be compiled with -i.

helpfile & more.help - Should have been edited before being posted.



The following were not in the 1.4a patches, but should be (patches
included below):


chmod(1) - Should return with exit(0).

uudecode(1) - Does not handle "`" substititing for " ".


Also, how does one win at ttt(1)?

			Edwin L. Froese
			  froese@mprgate.mpr.ca

			Terrence W. Holm
			  holm@bdc.ubc.ca

----------------------------------------------------------
echo x - chmod.c.cdif
sed '/^X/s///' > chmod.c.cdif << '/'
X*** chmod.c.1.3	Sat Oct  8 14:30:07 1988
X--- chmod.c	Sun Jan 29 15:15:04 1989
X***************
X*** 63,68 ****
X--- 63,70 ----
X              exit(1);
X          }
X      }
X+ 
X+     exit(0);
X  }
X  
X  
/
echo x - uudecode.c.cdi
sed '/^X/s///' > uudecode.c.cdi << '/'
X*** uudecode.c.1.3	Mon Aug  1 16:56:51 1988
X--- uudecode.c	Tue Feb  7 22:05:50 1989
X***************
X*** 114,120 ****
X  			printf("Short file\n");
X  			exit(10);
X  		}
X! 		n = tbuf[0] - ' ';
X  		if (n <= 0)
X  			break;
X  
X--- 114,120 ----
X  			printf("Short file\n");
X  			exit(10);
X  		}
X! 		n = DEC(tbuf[0]);
X  		if (n <= 0)
X  			break;
X  
/
----------------------------------------------------------