Path: utzoo!utgpu!watmath!julian!uwovax!7103_300
From: 7103_300@uwovax.uwo.ca (Eric Smith)
Newsgroups: comp.os.minix
Subject: Re: Atari ST mouse driver
Message-ID: <1778@uwovax.uwo.ca>
Date: 3 Mar 89 03:02:46 GMT
References: <1611@uwovax.uwo.ca> <646@Terra.cc.brunel.ac.uk>
Lines: 50
Organisation: University of Western Ontario, Canada

In article <646@Terra.cc.brunel.ac.uk>, ralph@cc.brunel.ac.uk (Ralph Mitchell) writes:
> The screen driver works like a charm, but I found a slight problem
> with the mouse driver.  I got:
> 
>   fs: filesystem panic: bad major device 7
> 
> It turns out that an entry needs to be made in the table of drivers in
> fs/table.c.  The last few lines should read like this:
> 
>         tty_open,  rw_dev,      no_call,    TTY,         /* 4 = /dev/tty0 */
>         no_call,   rw_dev2,     no_call,    TTY,         /* 5 = /dev/tty  */
>         no_call,   rw_dev,      no_call,    PRINTER,     /* 6 = /dev/lp   */
> ->      no_call,   rw_dev,      no_call,    MOUSE        /* 7 = /dev/mouse */
>     };
> 
>     int max_major = sizeof(dmap)/sizeof(struct dmap);
> 
> 
> I'm not 100% sure this is correct, but it works for me :-)  Perhaps Eric
> could confirm this ??  I guess he may have just overlooked this diff...
> 
> Recompiling with this fix makes the 'sketch' program work OK.
> 
> Ralph Mitchell
> -- 
>  From:  Ralph Mitchell at Brunel University, Uxbridge, UB8, 3PH, UK
>  JANET: ralph@uk.ac.brunel.cc	  ARPA:  ralph%cc.brunel.ac.uk@cwi.nl
>  UUCP:  ...ukc!cc.brunel!ralph   PHONE: +44 895 74000 x2561

Oops. You're absolutely right; I must have forgotten the patches (well, patch;
the one you just outlined) for fs. Sorry. Your suggested patch is exactly
what's needed. Thanks for pointing this out.

There's also a small bug in stmouse.c; around line 100 there's a line that
reads:

count = MIN(count, sizeof(mb));

It should read:

count = MIN(m_ptr->COUNT, sizeof(mb));

(the variable "count" isn't initialized at this point). This fix, and a few
more, are incorporated into my patch to the rs232 kernel (see next posting).
--
Eric R. Smith                      email:
Dept. of Mathematics               7103_300@uwovax.uwo.ca
University of Western Ontario      7103_300@uwovax.bitnet
London, Ont. Canada N6A 5B7    (a shared mailbox: put my name on
ph: (519) 661-3638              the Subj: line, please!)