Path: utzoo!utgpu!jarvis.csri.toronto.edu!mailrus!tut.cis.ohio-state.edu!ukma!xanth!cs.odu.edu!tadguy
From: tadguy@cs.odu.edu (Tad Guy)
Newsgroups: news.software.nntp
Subject: Re: Filesystem full patches?
Summary: yeah, well, gee...
Message-ID: <8351@xanth.cs.odu.edu>
Date: 5 Apr 89 03:11:55 GMT
References: <11896@shamash.cdc.com> <8159@xanth.cs.odu.edu> <1961@erix.ericsson.se>
Sender: news@cs.odu.edu
Reply-To: tadguy@cs.odu.edu (Tad Guy)
Organization: Old Dominion University, Norfolk, VA
Lines: 36
In-reply-to: per@erix.ericsson.se (Per Hedeland)

In article <1961@erix.ericsson.se>, per@erix (Per Hedeland) writes:
>I installed Tad's code (with some cosmetic changes: merged dfree() into
>space(), made the whole thing #ifndef USG rather than #ifdef ODU, and made
>both versions of space() return 0 if MINFREE wasn't #defined)

Yeah, well, gee.  The posting was ugly because I forced it together.
We have dfree() in a local library here, but for the posting I had to
include it as a separate file (yuck).  The #ifdef ODU's (the second
time I've ever used ODU as a conditional compilation token, something
I hope not to do again) were because of the prejudice of the space()
for USG.  All the space checking code really should be gated off some
other constant, like MINFREE, instead of being tied in with all the
USG stuff.

However, I felt it was more important to get the code out the door
than to make it look great.  I'm glad it works for you.  It's been a
great help here...

>							       - it works
>fine (still on a VAX/4.3BSD), and has had numerous opportunities to prove
>this during the last week... May I suggest that this be included in a
>future "official" patch?

I'd be happy to see it in a future release as well (less local mods
I'll have to merge in).  However, the code does need to be generalized
more...  If someone wants to do it, great!  (I have no incentive to do
it here until our VAX goes away...)

>(we generate the access file more or less automatically from name server 
>data).

There was patch a while back to allow wildcards in the nntp_access
file.  If there's interest, I can repost that patch (we have over a
hundred local machines, but only four lines in our nntp_access file).

	...tad