Path: utzoo!utgpu!jarvis.csri.toronto.edu!mailrus!tut.cis.ohio-state.edu!cs.utexas.edu!uunet!aecom!naftoli
From: naftoli@aecom.yu.edu (Robert N. Berlinger)
Newsgroups: comp.mail.mush
Subject: From: problem in Mush6.5
Message-ID: <2260@aecom.yu.edu>
Date: 22 May 89 21:38:42 GMT
Organization: Albert Einstein College of Medicine, NY
Lines: 36

There seems to be a bug in mush regarding the From: line.
Mush is not supposed to generate a From: line if PICKY_MAILER
is defined but it does if you *don't have edit_hdrs set*.

In mail.c/add_headers() line 1697, right before:

	if(!got_from)
	
I inserted the following:

#ifdef PICKY_MAILER
	if(i > 0)
#endif /* PICKY_MAILER */

This is my unofficial fix after about 10 minutes of looking at
the code, so wait for the mush gurus to have a chance to verify
the bug and fix before applying.  Nevertheless, it fixed the
problem for me :-).

In general, it seems to me like mush should not be messing around
with the From: and leave it to the MTA's who really know how
to deal with it (yeah right).  And if it is going to create one
(sometimes it must, for instance the record file), it should tack
on the complete domain name (at least optionally).  As it stands,
I don't think there's any way to get mush to know the local
domain name; it seems to rely on hostname only.

Also, I think smail2.5 is broken in this regard -- it seems be happy
to allow an incorrect user-specified From: to go out to the
world without as much as a warning.  So it's PICKY_MAILER for smail2.5
all the way.
-- 
Robert N. Berlinger		    |Domain: naftoli@aecom.yu.edu        
Supervisor of Systems Support	    |UUCP: {uunet}!aecom!naftoli
Scientific Computing Center	    |CompuServe: 73047,741 GEnie: R.Berlinger
Albert Einstein College of Medicine |Pan: berlinger  AppleLink: U0995