Path: utzoo!attcan!uunet!aecom!naftoli
From: naftoli@aecom.yu.edu (Robert N. Berlinger)
Newsgroups: comp.mail.mush
Subject: Two bugs in MUSH6.5
Keywords: reply headers
Message-ID: <2270@aecom.yu.edu>
Date: 26 May 89 16:09:45 GMT
Organization: Albert Einstein College of Medicine, NY
Lines: 46

I've stumbled upon what I think are two more bugs in mush.

The first is related to setting hostname to the host.domain 
name.  If, for example a message is received from joe@pc.abc.edu 
by joe@abc.edu, and joe@abc.edu has hostname set to abc.edu when 
he replies to the message (note that alts is not set), the reply 
is sent to "joe" (unqualified) instead of joe@pc.abc.edu.  This 
is because the take_me_off routine considers joe@pc.abc.edu to be 
the same person as joe@abc.edu.  

In addrs.c line 701 (take_me_off) mush does a comparison of the 
two addresses after having converted them into ! format and 
reversing them.  However, the comparison is only done for the 
length of abc.edu (reversed) rather than the length of 
pc.abc.edu, and since abc.edu is a substring of pc.abc.edu, the 
comparison succeeds and the addresses are considered equivalent.  
The fix (I think) would be to change 

		if (!lcase_strncmp(tmp, addr, strlen(tmp))) {
to
		if (!lcase_strncmp(tmp, addr, strlen(addr))) {

I didn't check the part of the code that deals with alts so there
may be something else there that needs looking at too.
Also, because of the way take_me_off is written, this is only a problem
if metoo is not set.

The second bug is that the headers routine (compose_hdr) seems to
consider only login (mailbox) name when deciding whether it should show the
the TO: type header (the recipients) or the normal header (the sender).
On line 373 of hdrs.c there is just this simple test:

    if (!strncmp(p, login, strlen(login))) {

where p points to (in the domain style case) the address in the 
'From:' line (in the case of ! style it will put p after the last 
!, i.e., the login name).  That means that any mail coming in 
with the same login name as your own will be considered by the header 
routine to have been sent by you even if it was sent from a different 
machine.  The setting of alts also seems to have no effect.  
This one is a bit hard to believe so maybe I'm off base.
-- 
Robert N. Berlinger		    |Domain: naftoli@aecom.yu.edu        
Supervisor of Systems Support	    |UUCP: {uunet}!aecom!naftoli
Scientific Computing Center	    |CompuServe: 73047,741 GEnie: R.Berlinger
Albert Einstein College of Medicine |Pan: berlinger  AppleLink: U0995