Path: utzoo!attcan!utgpu!jarvis.csri.toronto.edu!rutgers!deimos.cis.ksu.edu!uxc!uxc.cso.uiuc.edu!m.cs.uiuc.edu!ksung
From: ksung@m.cs.uiuc.edu
Newsgroups: comp.windows.x
Subject: Extension Bugs
Message-ID: <26900067@m.cs.uiuc.edu>
Date: 28 May 89 21:43:00 GMT
Lines: 37
Nf-ID: #N:m.cs.uiuc.edu:26900067:000:1224
Nf-From: m.cs.uiuc.edu!ksung    May 28 16:43:00 1989



I reported this problem in June 1988, and it is still there:


The documentation for Xserver extension says:
	SendErrorToClient (client, reqCode, minorCode, status, resId)

but the code in ./server/dix/extension.c says:
	SendErrorToClient (client, reqCode, minorCode, resId, status)
						       ^^^^^^^^^^^^^

and here is another problem with extensions:


The documentation for Xserver extension says:
	ExtensionEntry *AddExtension(name, NumEvents, NumErrors, MainProc, 
			      SwappedMainProc, SwapReplyProc, CloseDownProc)
					       ^^^^^^^^^^^^^

but in ./server/dix/extension.c the code looks like:
	ExtensionEntry *AddExtension(name, NumEvents, NumErrors, MainProc, 
			      SwappedMainProc, CloseDownProc)

Notice the missing SwapReplyProc argument. 
That means the XServer SwapReply Table is never set for the extension.
And none of the extension replies ever get swapped. In fact if the 
extension reply needs to be swapped, the server calls NotImplemented() 
and quits.

I am pretty sure our X source is up to date with all the reported 
bug fixes. So does this mean no one has ever written an 
extension with replies? Or do people find this bug and keep it 
to themselves?

Kelvin Sung
ksung@m.cs.uiuc.edu