Path: utzoo!utstat!helios.physics.utoronto.ca!jarvis.csri.toronto.edu!cs.utexas.edu!usc!apple!sun-barr!newstop!sun!amdahl!drivax!news
From: davison@drivax.UUCP (Wayne Davison)
Newsgroups: news.software.nn
Subject: Re: nnmaster dies
Message-ID: <66LFC0D@drivax.UUCP>
Date: 27 Feb 90 18:32:43 GMT
References: <5317@m2c.M2C.ORG> <LJZDKV2@drivax.UUCP> <1811@neon.siesoft.co.uk>
Sender: news@drivax.UUCP (news admin)
Organization: Digital Research, Monterey CA
Lines: 101

I wrote:
} If you have a pre-6.3.6 version of nn, you still have a bug in the name
} compression routine [...]

Duncan McEwan (duncan@helium.siesoft.co.uk) adds:
} I "discovered" a bug that sounds just like this one in my 6.3.1 sources
} last week, but on grabbing 6.3.7 over the weekend and having a quick
} look at it, the same bug still appears to be there

Ahh, the joys of nn patchlevels bit me on my oversimplification there.  As
mentioned before, the bug was fixed in usenet version 6.3.6, but not until
ftp version 6.3.8.  Patch #8 is only about 2K and fixes the name routine in
a similar manner to what you've already done.  It's so small, that I think
I'll follow Kim's recent example and simply include the patch on the end of
this message for all those people who missed it the last time.
-- 
Wayne Davison           \  /| / /| \/ /| /(_)    davison%drivax@uts.amdahl.com
davison@drivax.UUCP    (_)/ |/ /\| / / |/  \         ...!amdahl!drivax!davison
----8<------8<------8<------8<-----cut here----->8------>8------>8------>8----
From: storm@texas.dk 

This is patch #8 to nn release 6.3.

This patch redoes the fixes for the "long From: line bug" that was also
fixed in patch 6, but unfortunately "reverted" by patch 7 to align it
with the release 6.3.7 made available via anon-ftp before patch 6 was
posted.  See also patchlevel.h.

++Kim Storm

--------------------- CUT HERE ----------------------
*** /usr/storm/nn6.3.7/patchlevel.h	Fri Sep  8 12:46:52 1989
--- patchlevel.h	Fri Sep 15 19:05:47 1989
***************
*** 15,21 ****
   *	1989-08-22:  Patch 5: db.c
   *	1989-08-25:  Patch 6: admin.c pack_date.c
   *	1989-09-08:  Patch 7: several files
   */
  
! #define PATCHLEVEL 7
  
--- 15,34 ----
   *	1989-08-22:  Patch 5: db.c
   *	1989-08-25:  Patch 6: admin.c pack_date.c
   *	1989-09-08:  Patch 7: several files
+  *
+  *	NOTICE: Release 6.3.7 was distributed for anon-ftp before patch 6
+  *		was officially released on usenet.  Unfortunately, the
+  *		patch posted as #6 is not the patch #6 indicated above,
+  *		because the "Long From: line bug" fixed by the posted  
+  *		patch #6 was still present in the 6.3.7 available via ftp.
+  *
+  *	Therefore, future patches relating to 6.3.7 will use the normal
+  *	patch numbering scheme, while future patches to the originally
+  *	posted nn will be numbered 61, 62, etc. (if any - which I don't 
+  *	hope).
+  *
+  *	1989-09-15:  Patch 8: pack_name.c nntp.c
   */
  
! #define PATCHLEVEL 8
  

*** /usr/storm/nn6.3.7/pack_name.c	Fri Sep  8 12:46:52 1989
--- pack_name.c	Mon Sep 11 12:37:16 1989
***************
*** 183,188 ****
--- 183,189 ----
  	return 0;
  
      p = source, q = namebuf, n = 0;
+     maxq = namebuf + sizeof namebuf - 1;
      
  new_partition:
      for (i = SEP_MAXIMUM; --i >= 0; separator[i] = NULL);
***************
*** 211,216 ****
--- 212,218 ----
  	    continue;
  	}
  	if (n > 1) continue;
+ 	if (q >= maxq) break;
  	*q++ = c;
  	if (IS_SEPARATOR(c)) {
  	    switch (sep = (Class[c] & 0xff)) {

*** /usr/storm/nn6.3.7/nntp.c	Fri Sep  8 12:46:51 1989
--- nntp.c	Fri Sep 15 13:54:28 1989
***************
*** 44,49 ****
--- 44,51 ----
  
  import int errno, sys_nerr;
  import char *sys_errlist[];
+ extern int user_error();
+ extern int sys_error();
  
  #define syserr() (errno >= 0 && errno < sys_nerr ? \
  		  sys_errlist[errno] : "Unknown error.")
----8<------8<------8<------8<-----the end------>8------>8------>8------>8----