Xref: utzoo comp.mail.misc:3075 comp.sources.bugs:2292
Path: utzoo!attcan!uunet!jarthur!aqdata!sullivan
From: sullivan@aqdata.uucp (Michael T. Sullivan)
Newsgroups: comp.mail.misc,comp.sources.bugs
Subject: Bug in smail involving MAXCLEN
Message-ID: <1990Mar12.235134.22019@aqdata.uucp>
Date: 12 Mar 90 23:51:34 GMT
Organization: aQdata, Inc.  Western Region -- San Dimas, CA
Lines: 22

I recently started a mailing list so I wanted to bump up MAXCLEN in our
smail 2.5 to keep the number of uux calls down.  I bumped it up
and instead of keeping the calls down it actually started generating a
uux for just about each member of the alias I had set up.  After much
digging, I found out that MAXCLEN is pretty much not used in smail.
Because of this, buffers were overflowing and variables were coming
out weird.  Here is a diff of my changes to deliver.c:

67,69c67,69
< 	char lcommand[SMLBUF];		/* local command issued 	*/
< 	char rcommand[SMLBUF];		/* remote command issued	*/
< 	char scommand[SMLBUF];		/* retry  command issued	*/
---
> 	char lcommand[MAXCLEN];		/* local command issued 	*/
> 	char rcommand[MAXCLEN];		/* remote command issued	*/
> 	char scommand[MAXCLEN];		/* retry  command issued	*/
163a164
> 			 || ((send - scommand) > MAXCLEN)
-- 
Michael Sullivan          uunet!jarthur!aqdata!sullivan
aQdata, Inc.              sullivan@aqdata.uucp
San Dimas, CA             +1 714 599 9992