Path: utzoo!utgpu!jarvis.csri.toronto.edu!cs.utexas.edu!usc!ucsd!sdcc6!sdcc10!muller
From: muller@sdcc10.ucsd.edu (Keith Muller)
Newsgroups: comp.unix.wizards
Subject: Re: Error on "root device?"
Summary: bug in vax/swapgeneric.c
Keywords: tahoe installation error
Message-ID: <8340@sdcc6.ucsd.edu>
Date: 7 Mar 90 07:42:08 GMT
References: <1990Mar6.140639.7408@uncecs.edu>
Sender: news@sdcc6.ucsd.edu
Lines: 57

In article <1990Mar6.140639.7408@uncecs.edu>, khj@uncecs.edu (Kenneth H. Jacker) writes:
> Autoconfig spotted most of our devices including the uda50, ra0 and our
> DELUA.  The kernel then asked for the "root device", and here's where a
> problem arose.  I tried "ra0*", "ra00*", and even "ra0", but each gave
> the same error message:
> 
> 	use hp%d, up%d, ra%d, rb%d, rl%d, hk%d or kra%d.

A small bug in vax/swapgeneric.c

	Keith Muller
	University of California, San Diego
	muller@ucsd.edu

*** bad/vax/swapgeneric.c	Tue Jun  7 10:07:53 1988
--- good/vax/swapgeneric.c	Tue Feb  7 20:35:44 1989
***************
*** 81,94 ****
  		printf("root device? ");
  		gets(name);
  		for (gc = genericconf; gc->gc_driver; gc++)
! 		    for (cp = name, gp = gc->gc_name; *cp == *gp; cp++, gp++)
! 			if (*gp == 0)
  				goto gotit;
  		printf(
  		  "use hp%%d, up%%d, ra%%d, rb%%d, rl%%d, hk%%d or kra%%d\n");
  		goto retry;
  gotit:
! 		if (*cp < '0' || *cp > '9') {
  			printf("bad/missing unit number\n");
  			goto retry;
  		}
--- 81,94 ----
  		printf("root device? ");
  		gets(name);
  		for (gc = genericconf; gc->gc_driver; gc++)
! 		    for (cp = name, gp = gc->gc_name; *cp == *gp; cp++)
! 			if (*++gp == 0)
  				goto gotit;
  		printf(
  		  "use hp%%d, up%%d, ra%%d, rb%%d, rl%%d, hk%%d or kra%%d\n");
  		goto retry;
  gotit:
! 		if (*++cp < '0' || *cp > '9') {
  			printf("bad/missing unit number\n");
  			goto retry;
  		}
***************
*** 96,101 ****
--- 96,102 ----
  			unit = 10 * unit + *cp++ - '0';
  		if (*cp == '*')
  			swaponroot++;
+ 		goto found;
  	}
  	for (gc = genericconf; gc->gc_driver; gc++) {
  #if NMBA > 0